Improved mouse support #1481
Merged
Improved mouse support #1481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanslenders
force-pushed
the
better-mouse-support
branch
3 times, most recently
from
fffbd83 to
5daaafb
Compare
salt-die
reviewed
Aug 19, 2021
Comment on lines
+126
to
+138
| (35, 'M') : (NO_BUTTON, MOUSE_MOVE, NO_MODIFIER), # none_drag 35+ + + =35 | ||
| (39, 'M') : (NO_BUTTON, MOUSE_MOVE, SHIFT), # none_drag Shift 35+4+ + =39 | ||
| (43, 'M') : (NO_BUTTON, MOUSE_MOVE, ALT), # none_drag Alt 35+ +8+ =43 | ||
| (47, 'M') : (NO_BUTTON, MOUSE_MOVE, SHIFT_ALT), # none_drag Shift Alt 35+4+8+ =47 | ||
| (51, 'M') : (NO_BUTTON, MOUSE_MOVE, CONTROL), # none_drag Control 35+ + +16=51 | ||
| (55, 'M') : (NO_BUTTON, MOUSE_MOVE, SHIFT_CONTROL), # none_drag Shift Control 35+4+ +16=55 | ||
| (59, 'M') : (NO_BUTTON, MOUSE_MOVE, ALT_CONTROL), # none_drag Alt Control 35+ +8+16=59 | ||
| (63, 'M') : (NO_BUTTON, MOUSE_MOVE, SHIFT_ALT_CONTROL), # none_drag Shift Alt Control 35+4+8+16=63 |
There was a problem hiding this comment.
No button mouse movement is lowercase m on WSL. I'm not sure if it's a bug here or with windows.
There was a problem hiding this comment.
Yes, indeed. Possibly it's the Windows terminal.
There was a problem hiding this comment.
That's odd...is there a way to detect that? Or we could just detect both M and m
There was a problem hiding this comment.
You could just duplicate this block with a lowercase m for WSL if that's something you want to support.
Added more mouse support functionality, including the ability to discriminate which mouse button was pressed as well as reporting click-drags, and mouse movements when no mouse button is pressed. Also improved mouse support while text editing: when you click and drag, your selection will be shown in realtime (as opposed to having to release the mouse press to see the resulting selection). To see this functionality in action, try running examples/full-screen/text-editor.py, write some text, then click and drag over that text to select it. Commit co-authored by: Jonathan Slenders
jonathanslenders
force-pushed
the
better-mouse-support
branch
from
bed8b62 to
8137774
Compare
|
This is great! Is there anything I can help with to get this merged? |
|
@AnthonyDiGirolamo, I'm probably going to merge this. What needs to be done is the handling of all modifiers on Windows systems, but I don't have time to work on that right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added more mouse support functionality, including the ability to discriminate
which mouse button was pressed as well as reporting click-drags, and mouse
movements when no mouse button is pressed. Also improved mouse support while
text editing: when you click and drag, your selection will be shown in realtime
(as opposed to having to release the mouse press to see the resulting
selection).
To see this functionality in action, try running
examples/full-screen/text-editor.py, write some text, then click and drag over
that text to select it.
Original pull request: #1387
This PR takes the same changes, rebased on "master" + adds a few fixes related to Windows.
TODO: